Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return remediation steps with events #19853

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

ryan-carroll-graylog
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog commented Jul 8, 2024

Description

Adds remediation steps to general events details view.

Motivation and Context

Closes: #19354

How Has This Been Tested?

Locally in dev environment.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ryan-carroll-graylog
Copy link
Contributor Author

@zeeklop took a look at #19354 (comment) and it seemed like the path of least resistance was to just add a nullable remediation_steps to the event context. Let me know if y'all see any issues with this and if not I'll go ahead and move forward with this approach.
/cc @kingzacko1 @danotorrey

@zeeklop
Copy link
Contributor

zeeklop commented Jul 9, 2024

Thank you @ryan-carroll-graylog I'm taking a look now. Should I add the front-end changes to this branch?

@ryan-carroll-graylog
Copy link
Contributor Author

Thank you @ryan-carroll-graylog I'm taking a look now. Should I add the front-end changes to this branch?

No problem @zeeklop, yeah I think adding everything to this branch makes sense while we work out the details. I don't think it'll be a big changeset.

Copy link
Contributor

@zeeklop zeeklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Ryan. Tested successfully.

Copy link
Contributor

@kingzacko1 kingzacko1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryan-carroll-graylog ryan-carroll-graylog merged commit 0b90478 into master Jul 11, 2024
6 checks passed
@ryan-carroll-graylog ryan-carroll-graylog deleted the return-remediation-steps-with-events branch July 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Remediation Steps for each event to Alerts page
3 participants