Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create categories page #19852

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Conversation

simonychuang
Copy link
Contributor

@simonychuang simonychuang commented Jul 8, 2024

Adds first iteration of page in core to manage content categories. Allows basic CRUD operation with only the name field for now. Similar to Assets page categories management. UI will be improved in the next cycle, right now it's a very barebones implementation just to get the functionality in.

/nocl

How Has This Been Tested?

Tested manually on local env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@simonychuang simonychuang marked this pull request as ready for review July 8, 2024 18:20
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic functionality looks solid! I know there was talk about having the basic ability to add an entity id/type to a group, i.e. 2 more fields that take a type string/id combo and add to add to a group. But I don't think it's super important at this stage if there's other cycle work.

Just left one other comment about possibly tweaking the menu item name.

@@ -63,6 +63,7 @@ const navigationBindings: PluginExports = {
{ path: Routes.SYSTEM.LOOKUPTABLES.OVERVIEW, description: 'Lookup Tables', permissions: ['lookuptables:read'] },
{ path: Routes.SYSTEM.PIPELINES.OVERVIEW, description: 'Pipelines', permissions: ['pipeline:read', 'pipeline_connection:read'] },
{ path: Routes.SYSTEM.SIDECARS.OVERVIEW, description: 'Sidecars', permissions: ['sidecars:read'] },
{ path: Routes.SYSTEM.ENTITYGROUPS.OVERVIEW, description: 'Manage Entity Groups' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fit the pattern of the other items here to just have Entity Groups, with Manage being implied?

Suggested change
{ path: Routes.SYSTEM.ENTITYGROUPS.OVERVIEW, description: 'Manage Entity Groups' },
{ path: Routes.SYSTEM.ENTITYGROUPS.OVERVIEW, description: 'Entity Groups' },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-carroll-graylog Yup, that thought definitely crossed my mind but without any mockups at the moment and with the plan to continue working on this next cycle I decided to leave out the fields to add entities to a group for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok definitely makes sense to me to wait for mockups. The API is pretty simple for anyone wanting to use this as is anyway.

@simonychuang simonychuang merged commit 0a8936a into feature/add-categories Jul 9, 2024
6 checks passed
@simonychuang simonychuang deleted the content-categorization-page branch July 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants