-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make migration thread count counfigurable #19794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in general. Thank you for adding.
However, I cannot remove the value in the input field using the keyboard/mouse, I can only add to it.
Also, one small textual change.
...g2-web-interface/src/components/datanode/migrations/remoteReindexing/MigrateExistingData.tsx
Outdated
Show resolved
Hide resolved
@moesterheld the value is not supposed to be removed you can only replace the default value (4) with any positive integer. |
yep. never mind, I retried it and it behaves consistently with all other numeric input fields in Graylog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. I have a small comment.
value = e.target.value; | ||
|
||
if (e.target.name === 'threads') { | ||
value = Number(e.target.value) < 1 ? DEFAULT_THREADS_COUNT : Number(e.target.value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the getValueFromInput
from the FormUtils
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation and Context
fixes #19792
Screenshots (if appropriate):
Types of changes
Checklist: