-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive, outputs, pipelines, dataWarehouse column to stream overview #19763
Conversation
58d35f8
to
cdc8c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, it works as expected. Code LGTM.
Found one type nitpick.
streamDataWarehouseTableElements: { | ||
attributeName: string, | ||
attributes: any, | ||
columnRenderer: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we type safe these fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR adds new columns to stream the overview table to display:
/jpd Graylog2/graylog-plugin-enterprise#7624
Types of changes
Checklist: