Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove awsKeySecret & Fix Additional Fields toggle #424

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Remove awsKeySecret & Fix Additional Fields toggle #424

merged 1 commit into from
Mar 4, 2020

Conversation

kyleknighted
Copy link
Contributor

Removes warning that awsKeySecret cannot be found as it's no longer needed.

Also quickly fixed the mis-styled button on the AdditionalFields toggle.

image

cobaltclaudia
cobaltclaudia approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@cobaltclaudia cobaltclaudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lingpri
lingpri approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@lingpri lingpri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with 2 scenarios for this PR

  • set aws credentials in the default path using aws-cli2
  • manual key and secret.

@lingpri lingpri merged commit 4740993 into master Mar 4, 2020
@lingpri lingpri deleted the remove_aws_key branch March 4, 2020 19:02
dennisoelkers pushed a commit to Graylog2/graylog2-server that referenced this pull request Aug 29, 2023
@lingpri
Remove awsKeySecret (Graylog2/graylog-plugin-integrations#424)
7adfcfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingpri lingpri lingpri approved these changes

@cobaltclaudia cobaltclaudia cobaltclaudia approved these changes

Assignees
No one assigned
Labels
ready-for-review ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyleknighted @lingpri @cobaltclaudia