Determine language based on the OS' language [Rework] #262

midyh · 2021-02-07T18:57:57Z

Hi there.

Hopefully, this should be better:

I removed the default.json and added an object in languages.ts so that detecting it being picked is easier.
Also, to keep the languages' names, I implemented a switch statement. The only drawback is that when adding a new language, a new case must be added.

Please feel free to make any corrections! Thanks.

marc2332 · 2021-02-07T19:06:08Z

src/interface/core/lang_config.ts

+		// Get the language part from the locale (e.g. en-GB -> en)
+		const locale = globalAny.navigator.language.substr(0, globalAny.navigator.language.indexOf('-'))
+
+		switch (locale) {


I don't really think this switch is needed, each language already provides a locale, example:

Graviton-App/languages/english.json

Line 3 in 09618d0

"locale": "en",

marc2332 · 2021-02-08T11:52:44Z

src/interface/core/lang_config.ts

@@ -31,53 +31,19 @@ function setFallback(notFoundLang: string): void {
 StaticConfig.keyChanged('appLanguage', (newLanguage: string) => {
 	if (Languages[newLanguage].name === 'Default') {
 		// Get the language part from the locale (e.g. en-GB -> en)
-		const locale = globalAny.navigator.language.substr(0, globalAny.navigator.language.indexOf('-'))
+		const newLocale = globalAny.navigator.language.substr(0, globalAny.navigator.language.indexOf('-'))


I think it would be better to use this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale

Example:

const { language } = new Intl.Locale(globalThis.navigator.language)

Using Intl.Locale returns Property 'Locale' does not exist on type 'typeof Intl'. Do you have any solutions for this in mind?

Using Intl.Locale returns Property 'Locale' does not exist on type 'typeof Intl'. Do you have any solutions for this in mind?

Where did you test it? It worked fine for me.

Where did you test it? It worked fine for me.

I am currently testing on Ubuntu 20.10.

Edit: I just found a workaround. Using new (Intl as any).Locale(...) actually worked, so it's probably an error in the .d.ts file of Intl.

Where did you test it? It worked fine for me.

I am currently testing on Ubuntu 20.10.

I mean, where are you executing that code? Node? Electron? Firefox?

I mean, where are you executing that code? Node? Electron? Firefox?

Electron.

I mean, where are you executing that code? Node? Electron? Firefox?

Electron.

Show me the error, please.

Here is the console output:

↳✨ Watching in WatchWebpackRenderer ↳❌ [webpack] Error in: ./src/interface/core/lang_config.ts [tsl] ERROR in /home/user/Coding/Graviton-App/src/interface/core/lang_config.ts(33,33) TS2339: Property 'Locale' does not exist on type 'typeof Intl'.

And line 33:

const { language } = new Intl.Locale(globalThis.navigator.language)

Also, using (Intl as any).Locale(...) works normally.

Here is the console output:

↳✨ Watching in WatchWebpackRenderer ↳❌ [webpack] Error in: ./src/interface/core/lang_config.ts [tsl] ERROR in /home/user/Coding/Graviton-App/src/interface/core/lang_config.ts(33,33) TS2339: Property 'Locale' does not exist on type 'typeof Intl'.

And line 33:

const { language } = new Intl.Locale(globalThis.navigator.language)

Also, using (Intl as any).Locale(...) works normally.

Related to microsoft/TypeScript#37326 .

I think it would be better to just leave it as it is for now

marc2332 · 2021-02-10T11:03:52Z

I was thinking about if it would be better if it was a switch button rather than another radio button, what do you think?

It would say something like "Use System's preference"

ghost · 2021-02-10T13:54:34Z

I was thinking about if it would be better if it was a switch button rather than another radio button, what do you think?

It would say something like "Use System's preference"

A switch would be too much, since if it is disabled, there would be another menu.

Maybe a "Reset language" button that resets the language to this?

midyh · 2021-02-11T13:42:57Z

A switch would be too much, since if it is disabled, there would be another menu.

I agree with @dragonDScript. If for example a user needed to switch languages they would have to turn off the switch and then choose. So yes I think a switch would complicate things.

Maybe a "Reset language" button that resets the language to this?

That's a good idea, but I think we should include the setting in the radio button so the user can know which one is in use.

marc2332 · 2021-02-11T14:07:02Z

I don't see any issue with something like:

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

ghost · 2021-02-11T15:46:53Z

I don't see any issue with something like:

That is bad for UX. E.g. A user sets their language to russian. Then, he enables use system's preference. What language is being used? The system's or russian?

marc2332 · 2021-02-11T15:48:50Z

I don't see any issue with something like:

That is bad for UX. E.g. A user sets their language to russian. Then, he enables use system's preference. What language is being used? The system's or russian?

Enabling that switch would automatically change the selected radio button. And when you manually click on a radio button it would disable the switch.

ghost · 2021-02-11T15:49:48Z

I don't see any issue with something like:

That is bad for UX. E.g. A user sets their language to russian. Then, he enables use system's preference. What language is being used? The system's or russian?

Enabling that switch would automatically change the selected radio button. And when you manually click on a radio button it would disable the switch.

or make the radio gray to denote that it is 'invalid' or disabled.

ghost · 2021-02-11T15:51:02Z

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

And that's why I suggested the button way. This way, appLanguage wouldn't be affected and you wouldn't need an extra switch.
E.g. the button would set the current language to the system's and update the radio button.

marc2332 · 2021-02-11T15:56:25Z

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

And that's why I suggested the button way. This way, appLanguage wouldn't be affected and you wouldn't need an extra switch.
E.g. the button would set the current language to the system's and update the radio button.

Makes more sense to use a switch because its a thing you enable and disable. If you ever change your System's language it would change the app language too. You don't have to click the switch every time you change your system's language

ghost · 2021-02-11T16:16:42Z

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

And that's why I suggested the button way. This way, appLanguage wouldn't be affected and you wouldn't need an extra switch.
E.g. the button would set the current language to the system's and update the radio button.

Makes more sense to use a switch because its a thing you enable and disable. If you ever change your System's language it would change the app language too. You don't have to click the switch every time you change your system's language

But this feature could detect the os' language on every launch and update it. In my way, the API is not affected.

marc2332 · 2021-02-11T22:39:33Z

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

And that's why I suggested the button way. This way, appLanguage wouldn't be affected and you wouldn't need an extra switch.
E.g. the button would set the current language to the system's and update the radio button.

Makes more sense to use a switch because its a thing you enable and disable. If you ever change your System's language it would change the app language too. You don't have to click the switch every time you change your system's language

But this feature could detect the os' language on every launch and update it. In my way, the API is not affected.

By adding an extra setting, which would be something like appUseSystemLanguage, we keep appLanguage behavior as it is now. This new setting would be a boolean, so it makes sense to use a switch.

ghost · 2021-02-12T19:02:17Z

Also, from the developer perspective it's better to don't include non-languages options in the settings 'appLanguage', think aboiut a plugin that wants to know what language is being used, that's easy to do by just reading StaticConfig.data.appLanguage, but, by doing that, you wouldn't be able to know what language is really being used.

And that's why I suggested the button way. This way, appLanguage wouldn't be affected and you wouldn't need an extra switch.
E.g. the button would set the current language to the system's and update the radio button.

Makes more sense to use a switch because its a thing you enable and disable. If you ever change your System's language it would change the app language too. You don't have to click the switch every time you change your system's language

But this feature could detect the os' language on every launch and update it. In my way, the API is not affected.

By adding an extra setting, which would be something like appUseSystemLanguage, we keep appLanguage behavior as it is now. This new setting would be a boolean, so it makes sense to use a switch.

This would cause a lot of bugs. I can't really explain, I had similar issues in the past with this kind of two-settings layout.

midyh added 5 commits February 7, 2021 14:46

Use navigator.language

2e9ea4e

Add fallback to english

760770a

Fix typo

2161a29

Add switch statement

24d98e8

Delete default.json

5ad69a0

marc2332 reviewed Feb 7, 2021

View reviewed changes

Replace switch with an object loop

d1d239c

marc2332 reviewed Feb 8, 2021

View reviewed changes

marc2332 self-assigned this Feb 9, 2021

marc2332 added the need-to-review It needs to be fully reviewed label Feb 9, 2021

ghost mentioned this pull request Feb 13, 2021

[Suggestion] Determine language based on the OS' language #251

Closed

marc2332 linked an issue Feb 13, 2021 that may be closed by this pull request

[Suggestion] Determine language based on the OS' language #251

Closed

marc2332 merged commit e1c12d7 into Graviton-Code-Editor:master Feb 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Determine language based on the OS' language [Rework] #262

Determine language based on the OS' language [Rework] #262

midyh commented Feb 7, 2021

marc2332 Feb 7, 2021

marc2332 Feb 8, 2021

midyh Feb 8, 2021

marc2332 Feb 8, 2021

midyh Feb 8, 2021 •

edited

Loading

marc2332 Feb 8, 2021

midyh Feb 8, 2021

marc2332 Feb 8, 2021

midyh Feb 8, 2021

marc2332 Feb 9, 2021

marc2332 commented Feb 10, 2021 •

edited

Loading

ghost commented Feb 10, 2021

midyh commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 12, 2021

Determine language based on the OS' language [Rework] #262

Determine language based on the OS' language [Rework] #262

Conversation

midyh commented Feb 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

midyh Feb 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marc2332 commented Feb 10, 2021 • edited Loading

ghost commented Feb 10, 2021

midyh commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 11, 2021

marc2332 commented Feb 11, 2021

ghost commented Feb 12, 2021

midyh Feb 8, 2021 •

edited

Loading

marc2332 commented Feb 10, 2021 •

edited

Loading