Add support for setting video frame rate #436
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHShetty
force-pushed
the
video_frame_rate
branch
from
8427d99 to
e7571b6
Compare
muhomorr
requested changes
Jun 24, 2024
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
a8a8831 to
5322053
Compare
muhomorr
requested changes
Jun 26, 2024
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
c41cd08 to
499bcfc
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
from
499bcfc to
bc0438d
Compare
MHShetty
force-pushed
the
video_frame_rate
branch
2 times, most recently
from
5712181 to
4d75174
Compare
|
The video frame rate despite being set correctly doesn't seem to reflect on the video currently. We could merge this PR once this gets resolved on CameraX |
(for frame rate per second setting)
(in quick settings dialog)
(show appropriate options in dropdown and selection of default fps)
(and prevent crash when video mode is directly turned on)
(for frame rate per second setting)
MHShetty
force-pushed
the
video_frame_rate
branch
from
4d75174 to
655f6aa
Compare
|
The latest changes made in the recent release does fix the issue with uncertainties with lower ranges on my Pixel 7A. However, the issue still persists for 60 fps, where recording a video while choosing a 60-fps range (from the list of supported ranges reported by the library) doesn't make the fps of the recorded video close to the selected range. Have filed an issue for the same on CameraX's issue tracker: https://issuetracker.google.com/issues/384146331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to set fps of the video being recorded (Issue #51)
(Needs testing to check if the set fps actually reflects in the video across different devices, especially at 60 fps for devices that support it)