Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup dataListeners #6098

Merged
merged 1 commit into from
Aug 31, 2024
Merged

refactor: cleanup dataListeners #6098

merged 1 commit into from
Aug 31, 2024

Conversation

danstarns
Copy link
Member

@danstarns danstarns mentioned this pull request Aug 30, 2024
Merged
@danstarns
Copy link
Member Author

@artf I find it concerning that this change was not detected in the tests, IE - no changes were needed or none failed. Does that mean the Data Sources tests are not as comprehensive as I believe them to be, or is detecting a change of the default value needed at all?

@artf
Copy link
Member

artf commented Aug 31, 2024

@danstarns good question, the reason this was not detected:

  • You don't have a test case when you update defaultValue
  • You don't count how many times updateValueFromDataVariable is called

The first one, in my opinion, it would be nice to cover.

@artf artf merged commit a22c4fe into dev Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artf artf artf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danstarns @artf