Add node sass import #2859
Closed
Add node sass import #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @WayneHarris it sounds good! I'll give it a try w/ a react project to see if it works as expected but regarding your commits it should not cause that many troubles! |
|
@artf I'll try to find some time to look into dart-sass, as I've been meaning to for another a project anyway. Also, node-sass can be a pain with builds due to its building of binaries on different OS. |
|
Thanks @WayneHarris I really appreciate your help |
|
With this PR, made by @cvrajeesh, we can finally close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @8byr0 @artf
Regarding the revert of the sass imports update;
6aa1828
and the issues raised here;
#2747
Could you consider using node-sass-import as shown in this PR?
build:css script seems to work as expected and this allows the support of theming as per the documents which suggest you can import the main.scss to set variables.
https://grapesjs.com/docs/getting-started.html#theming