Placeholder color as a variable

[jcamejo]

Hi @artf, i hope you are doing ok during these strange times.

This small improvement adds a CSS variable to make it possible to change the placeholder bar separately. I have removed the border-color property from the gjs-placeholder class because it always gets overwritten by the sorter function and it was causing a bit of confusion to understand where the color was coming from.

I've added the placeholder color as an constructor option in the sorter object just to make it more clear. It would be nice to find a way to synchronize the Sass variables so there's no need to maintain two variables, I'm not sure if this is actually possible without a custom solution.

Let me know what you think.

Best Regards,

Juan.

[artf]

Thanks @jcamejo actually you're right, it would be great to remove the color reference from the JS file because it's absolutely bad and hard to customize.
The reason behind this choice is was to create this effect

which has different border colors values base on the fact if the placeholder is placed vertically or horizontally.
Don't ask me why I didn't think about using a simple class as a flag to manage this state, but as the code is old I guess it was just inexperience.

Would you like to update this PR to make it work only with the CSS variable and remove the reference from the sorter? I'd really appreciate that :)

If you have any doubt about how to achieve it by using only a class, don't hesitate to ask

[jcamejo]

I would like to improve the pull request, i will take a look at it soon.

Thanks for the tip, i will ask if i need some assistance.

[jcamejo]

Hi @artf, good day to you.

I have moved the placeholder color and the orientation properties to the CSS files, let me know what you think.

I was playing with moving the placeholder dimensions properties to SCSS variables as well but i don't think is necessary at this point.

[artf]

Great @jcamejo now it makes much more sense :)