making the external assets form optional #2602
Conversation
|
Yeah cool, seems like a good idea 👍, but can you check the failing tests, please? |
|
Sorry for leaving that behind, the tests are added. There are some redeclarations of the test object to make clear that the view is being initialized with the correct config |
src/asset_manager/view/AssetsView.js
Outdated
| @@ -56,7 +56,7 @@ export default Backbone.View.extend({ | |||
| const url = input.value.trim(); | |||
| const handleAdd = this.config.handleAdd; | |||
|
|
|||
| if (!url) { | |||
| if (!url || !input) { | |||
There was a problem hiding this comment.
mmm this !input check doesn't make sense here, it that case it would crash at input.value.trim()
|
Absolutely right, it's changed. |
|
I'm not sure if this failure has something to do with the change, it does not look like it. I've merged the dev branch to have the latest state. Should i check some other module that I'm not aware of? Thanks again for your assistance. |
Nope, my fault 😬 Thanks for the contribution Juan |
Hi @artf i hope you are having a nice day.
What do you think of this small improvement? I just got a use case where i needed to have this option and i think is a good idea.
Thanks!