Asset Manager Upload / Store file Limit #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the user from exceeding their limit.
artf
requested changes
Sep 3, 2019
| } | ||
| if (config.uploadMaxFileSize > 0 && config.uploadMaxFileSize <= fileSize / 1024) { | ||
| alert(config.uploadMaxFileSizeAlertText || 'The file(s) you have selected to add exceed your space limit'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
IMHO, instead of those 2 options, I'd prefer something like config.beforeUpload callback where the user can define its own logic and raise its own UI (we shouldn't use alert in the framework, if you feel the need to do it, it means you have to create a customizable callback for the user). Eg.
const { beforeUpload } = config;
const beforeUploadRes = beforeUpload &&
beforeUpload({ fileSize, files, ...maybeOtherOptions });
if (beforeUploadRes === false) return;| @@ -115,12 +115,20 @@ export default Backbone.View.extend( | |||
| body.append(param, params[param]); | |||
| } | |||
|
|
|||
| var fileSize = 0; | |||
|
@artf, I made the changes you requested; which makes this a lot cleaner and better for me too. Thank you. Do I need to do a new pull request or is this sufficient? |
artf
approved these changes
Sep 4, 2019
No, it's perfect now, thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asset manager added config & logic to set max file(s) size; preventing the user from exceeding their limit.