Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Selection & active RTE not cleared when component is removed programatically #3175

Closed
mcottret opened this issue Dec 9, 2020 · 1 comment

Comments

@mcottret
Copy link

mcottret commented Dec 9, 2020

Version: 0.16.30

Are you able to reproduce the bug from the demo?

[x] Yes
[ ] No

Steps to reproduce:

  • Select a text component in the demo's canvas
  • The selection box & RTE appear
  • Open the console
  • Execute editor.setComponents('');
  • The component is removed, but the selection box & RTE are still present (see attached screenshot)

What is the expected behavior?

When programatically removing a selected component with an active RTE, the selection & active RTE should be cleared.

What is the current behavior?

Component selection & RTE stay active on top of an unexisting component. Component selection disappears when clicked, but the RTE does not & causes an error.

Proposed solution:

As always, I'd be happy to take care of the PR if this looks good to you !

Are you able to attach screenshots, screencasts or a live demo?

[x] Yes (attach)
[ ] No

Screenshot 2020-12-09 at 11 08 41 AM

@artf
Copy link
Member

artf commented Dec 29, 2020

Thanks @mcottret for the report. I've handled this on my side, so it should be fixed in the next release, but as always, thanks for your willingness to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants