Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: "display" property of Style Manager doesn't sync with Layer Manager #2938

Closed
tranthanhhoa opened this issue Aug 4, 2020 · 2 comments
Closed

BUG: "display" property of Style Manager doesn't sync with Layer Manager #2938

tranthanhhoa opened this issue Aug 4, 2020 · 2 comments

Comments

@tranthanhhoa
Copy link

Version: v0.16.18

How to reproduce:

  • Select a component
  • Choose Layer tab
  • Hide component
  • Back to Style tab
  • Check "display" property
    Alt Text

Expected:

  • "display" should be "none"

Actually:

  • "display" is still "block"
@tranthanhhoa tranthanhhoa changed the title BUG: "display" property doesn't sync with Layer handle BUG: "display" property doesn't sync with Layer Aug 4, 2020
@tranthanhhoa tranthanhhoa changed the title BUG: "display" property doesn't sync with Layer BUG: "display" property of Style Manager doesn't sync with Layer Aug 4, 2020
@tranthanhhoa tranthanhhoa changed the title BUG: "display" property of Style Manager doesn't sync with Layer BUG: "display" property of Style Manager doesn't sync with Layer Manager Aug 4, 2020
@Ju99ernaut
Copy link
Contributor

The StyleManager doesn't seem to update when styles are changed from somewhere else...the display property does get updated once you deselect and select the component again. Probably the StyleManager needs to updated to listen for changes to display property from the LayerManager.

@artf
Copy link
Member

artf commented Aug 27, 2020

Will be fixed in the next release. Thanks

@artf artf closed this as completed in b9bd718 Aug 28, 2020
vijayshukla30 pushed a commit to vijayshukla30/grapesjs that referenced this issue Sep 7, 2020
@artf @vijayshukla30
Update Style Manager on Layer visibility change. Fixes GrapesJS#2938
fcb4221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tranthanhhoa @artf @Ju99ernaut