Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Resizing frame may be positioned around invalid element #2876

Closed
fedulovivan opened this issue Jul 4, 2020 · 1 comment
Closed

[Bug] Resizing frame may be positioned around invalid element #2876

fedulovivan opened this issue Jul 4, 2020 · 1 comment
Labels
bug

Comments

@fedulovivan
Copy link

fedulovivan commented Jul 4, 2020 •
edited
Loading

Steps to reproduce:

  • open newsletter demo at https://grapesjs.com/demo-newsletter-editor.html
  • clean canvas
  • place "1/3 section"
  • place "Image" in the middle column
  • try to resize image - works correctly
  • move selection to images's parent with click on upper arrow -
    image
  • resizing frame was moved to table cell which is incorrect. actioning with it impacts the image - works wrongly
  • moving selection to parent makes frame to appear for table. actioning with it still impacts the image - works wrongly

See demo:
https://github.com/fedulovivan/misc/blob/master/Jul-04-2020%2011-49-35.gif
@fedulovivan fedulovivan changed the title Bug: Resizing frame may be positioned around invalid element [Bug] Resizing frame may be positioned around invalid element Jul 6, 2020
@artf
Copy link
Member

artf commented Jul 15, 2020

Nice, it will be fixed in the next release

@artf artf added the bug label Jul 15, 2020
@artf artf closed this as completed in 44a500e Jul 21, 2020
cartifon pushed a commit to cartifon/grapesjs that referenced this issue Jul 27, 2020
@artf @cartifon
Ensure resizer on the correct component. Fixes GrapesJS#2876
def1887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedulovivan @artf