Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Link target does not propagate to model #2411

Closed
senchden opened this issue Nov 14, 2019 · 0 comments
Closed

[Bug]: Link target does not propagate to model #2411

senchden opened this issue Nov 14, 2019 · 0 comments
Labels
bug

Comments

@senchden
Copy link

Expected behaviour:
When changing existing link with target = "_blank" to target ="", the change propagates to html.

Actual behaviour:
When changing existing link with target = "_blank" to target ="", the change does not propagate to html.

Steps to reproduce:

  1. Save a page with link with target "New window" ("_blank").
  2. Close and reopen the editor.
  3. Change the link target to "This window" (empty string). Observe the change not propagating.

Reproducible with the web page demo v.0.15.8

Attaching the screencast:
link-target-bug
@artf artf added the bug label Nov 17, 2019
@artf artf closed this as completed in 68f5cc6 Nov 17, 2019
xiyangliu added a commit to xiyangliu/grapesjs that referenced this issue Feb 11, 2020
@xiyangliu
Merge commit '68f5cc61a9808f4cb093228edd1b9eecc5d005b2' into HEAD
ed9341a 
* commit '68f5cc61a9808f4cb093228edd1b9eecc5d005b2':
  Update href trait value. Closes GrapesJS#2411
  Clear modules before load. Fixes GrapesJS#2402
  Update getCacheLoad function
  Preserve selection after `canvas:drop`. Closes GrapesJS#2396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artf @senchden