Skip to content

[Bug]: If devices in DeviceManager all have a width specificed an editor breaking error occurs #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skateborden opened this issue Feb 25, 2019 · 1 comment

Comments

@skateborden
Copy link

If all devices specified for the DeviceManager have a width set, an editor breaking error occurs: "TypeError: contRules is null". I'm seeing this in my local project with v0.14.52.

jsfiddle: https://jsfiddle.net/5ycmoftj/1/

I think what is happening is that CssRulesView.js render() is creating div fragments as containers for different media targets, based on the widths of the devices in the device manager. If you don't have a device set up with a undefined width, there is no place for css rules that don't specify a media width to go. It doesn't create a container for them.

@artf artf added the bug label Mar 3, 2019
@artf artf closed this as completed in 2b45543 Mar 9, 2019
debba pushed a commit to debba/grapesjs that referenced this issue Mar 12, 2019
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants