Cleanups of resolve
#1620
Merged
Cleanups of resolve
#1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the resolve method implementations in two dependency filter classes to improve code clarity and eliminate redundant helper methods.
- Replaces generic lambda parameter
itwith more descriptivedepvariable name - Inlines the
isParentExcludedhelper method inMinimizeDependencyFilterwith a more concise implementation - Maintains identical functionality while reducing code complexity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MinimizeDependencyFilter.kt | Inlines isParentExcluded method and improves variable naming |
| DefaultDependencyFilter.kt | Updates lambda parameter name for consistency |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt
Outdated
Show resolved
Hide resolved
…ernal/MinimizeDependencyFilter.kt Co-authored-by: Copilot <[email protected]>
Goooler
force-pushed
the
g/20250809/in-parents
branch
from
47465b2 to
ed4782e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.