Replace remaining urrlib2 usage with requests. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
force-pushed
the
purge-urllib2
branch
from
d2a671e to
5969ed2
Compare
|
I (thankfully) haven't had occasion to use ActiveCollab for years, so I can't really give this a meaningful review, sorry @ralphbean! |
|
@ryneeverett, ok, we waited long enough. It looks fine to me so I'm 👍 to merge. |
|
Yeah, unfortunately this is the best we can do with services we don't use at this point. The solution is more/better tests, but that is my primary motivation behind this PR -- mocking requests is so much easier than urllib2. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I do not have any way to test this out on these services.