Public service documentation #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- contributing/getting-started.rst -> contributing.rst - contributing/new-services.rst -> other_services/tutorial.rst
This reverts commit 1dbde51. It turns out a better way to limit the public API seems to be through the __all__ attribute. I manually deleted the `include` and `get_owner` methods from the base `Service` class since the pure `git revert` recovers them.
ryneeverett
force-pushed
the
public-service-documentation
branch
2 times, most recently
from
548a4b7 to
4b179e5
Compare
ryneeverett
force-pushed
the
public-service-documentation
branch
from
4b179e5 to
aa4b199
Compare
It's been EOL for over a year. We need typing-extensions' backport of typing.Literal in order to support python-3.7, which is triggering a problem with intersphinx in CI. Removing typing-extensions solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.