chore(build): Bump Typescript to 3.9.2

Generate type files for older typescript compilers Fixed issues relating to: microsoft/TypeScript#36696 Signed-off-by: Gordon Smith <[email protected]>
GordonSmith · May 22, 2020 · c91fe96 · c91fe96
1 parent 7831eb2
commit c91fe96
Show file tree

Hide file tree

Showing 44 changed files with 361 additions and 249 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,6 +4,7 @@
 dist
 lib
 types
+types-3.4
 node_modules
 build
 review/api/temp

diff --git a/examples/example-datagrid/package.json b/examples/example-datagrid/package.json
@@ -18,7 +18,7 @@
     "file-loader": "^5.0.2",
     "rimraf": "^2.5.2",
     "style-loader": "^1.0.2",
-    "typescript": "~3.6.4",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   }

diff --git a/examples/example-datastore/package.json b/examples/example-datastore/package.json
@@ -27,7 +27,7 @@
     "file-loader": "^5.0.2",
     "rimraf": "^2.5.2",
     "style-loader": "^1.0.2",
-    "typescript": "~3.6.4",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3"
   }
 }
diff --git a/examples/example-datastore/src/messages.ts b/examples/example-datastore/src/messages.ts
@@ -38,7 +38,7 @@ namespace WSAdapterMessages {
    * A base message for the patch server.
    */
   export
-  type IBaseMessage = JSONObject & {
+  interface IBaseMessage extends Partial<JSONObject> {
     msgId: string;
     msgType: (
       'storeid-request' | 'storeid-reply'|
@@ -48,13 +48,13 @@ namespace WSAdapterMessages {
       'history-request' | 'history-reply' |
       'fetch-transaction-request' | 'fetch-transaction-reply'
     );
-    parentId: undefined;
+    parentId?: string;
 
     readonly content: ReadonlyJSONObject;
   }
 
   export
-  type IBaseReplyMessage = IBaseMessage & {
+  interface IBaseReplyMessage extends IBaseMessage {
     parentId: string;
   }
 
@@ -71,7 +71,7 @@ namespace WSAdapterMessages {
    * A reply from the server containing a unique store ID.
    */
   export
-  type IStoreIdMessageReply = IBaseReplyMessage & {
+  interface IStoreIdMessageReply extends IBaseReplyMessage {
     msgType: 'storeid-reply';
     content: {
       readonly storeId: number

diff --git a/examples/example-datastore/src/wsbase.ts b/examples/example-datastore/src/wsbase.ts
@@ -21,7 +21,7 @@ import {
  * Abstract base for a class that sends/receives messages over websocket.
  */
 export
-abstract class WSConnection<T extends JSONValue, U extends JSONValue> implements IDisposable {
+abstract class WSConnection<T extends Partial<JSONValue>, U extends Partial<JSONValue>> implements IDisposable {
   /**
    * Create a new websocket based connection.
    */

diff --git a/examples/example-dockpanel/package.json b/examples/example-dockpanel/package.json
@@ -20,7 +20,7 @@
     "rimraf": "^2.5.2",
     "source-map-loader": "0.2.4",
     "style-loader": "^1.0.2",
-    "typescript": "~3.6.4",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   }

diff --git a/packages/algorithm/package.json b/packages/algorithm/package.json
@@ -21,18 +21,27 @@
   "files": [
     "dist/*",
     "src/*",
-    "types/*"
+    "types/*",
+    "types-3.4/*"
   ],
   "main": "dist/index.js",
   "module": "dist/index.es6",
   "unpkg": "dist/index.min.js",
   "jsdelivr": "dist/index.min.js",
   "types": "types/index.d.ts",
+  "typesVersions": {
+    "<3.8": {
+      "*": [
+        "types-3.4/index.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "api": "api-extractor run --local --verbose",
     "minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
-    "build": "tsc --build && rollup -c",
+    "build": "tsc --build && npm run gen-legacy-types && rollup -c",
     "build:test": "tsc --build tests && cd tests && webpack",
+    "gen-legacy-types": "downlevel-dts ./types ./types-3.4",
     "clean": "rimraf ./lib && rimraf *.tsbuildinfo && rimraf ./types && rimraf ./dist",
     "clean:test": "rimraf tests/build",
     "docs": "typedoc --options tdoptions.json src",
@@ -45,6 +54,7 @@
   "devDependencies": {
     "@microsoft/api-extractor": "^7.6.0",
     "@types/mocha": "^2.2.39",
+    "downlevel-dts": "^0.4.0",
     "tslib": "1.10.0",
     "chai": "^3.5.0",
     "karma": "^4.4.1",
@@ -60,12 +70,12 @@
     "rollup-plugin-sourcemaps": "^0.5.0",
     "rollup-plugin-postcss": "^2.0.3",
     "terser": "^4.6.2",
-    "typedoc": "~0.15.0",
-    "typescript": "~3.6.4",
+    "typedoc": "~0.17.7",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   },
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/algorithm/tdoptions.json b/packages/algorithm/tdoptions.json
@@ -2,7 +2,7 @@
   "excludeNotExported": true,
   "mode": "file",
   "target": "es5",
-  "module": "es5",
+  "module": "es6",
   "lib": ["lib.es2015.d.ts", "lib.es2015.collection.d.ts", "lib.es2015.promise.d.ts", "lib.dom.d.ts"],
   "out": "../../docs/api/algorithm",
   "baseUrl": ".",

diff --git a/packages/application/package.json b/packages/application/package.json
@@ -21,18 +21,27 @@
   "files": [
     "dist/*",
     "src/*",
-    "types/*"
+    "types/*",
+    "types-3.4/*"
   ],
   "main": "dist/index.js",
   "module": "dist/index.es6",
   "unpkg": "dist/index.min.js",
   "jsdelivr": "dist/index.min.js",
   "types": "types/index.d.ts",
+  "typesVersions": {
+    "<3.8": {
+      "*": [
+        "types-3.4/index.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "api": "api-extractor run --local --verbose",
     "minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
-    "build": "tsc --build && rollup -c",
+    "build": "tsc --build && npm run gen-legacy-types && rollup -c",
     "build:test": "tsc --build tests && cd tests && webpack",
+    "gen-legacy-types": "downlevel-dts ./types ./types-3.4",
     "clean": "rimraf ./lib && rimraf *.tsbuildinfo && rimraf ./types && rimraf ./dist",
     "clean:test": "rimraf tests/build",
     "docs": "typedoc --options tdoptions.json src",
@@ -51,6 +60,7 @@
     "@microsoft/api-extractor": "^7.6.0",
     "@types/chai": "^3.4.35",
     "@types/mocha": "^2.2.39",
+    "downlevel-dts": "^0.4.0",
     "tslib": "1.10.0",
     "chai": "^3.5.0",
     "karma": "^4.4.1",
@@ -66,12 +76,12 @@
     "rollup-plugin-sourcemaps": "^0.5.0",
     "rollup-plugin-postcss": "^2.0.3",
     "terser": "^4.6.2",
-    "typedoc": "~0.15.0",
-    "typescript": "~3.6.4",
+    "typedoc": "~0.17.7",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   },
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/application/tdoptions.json b/packages/application/tdoptions.json
@@ -2,7 +2,7 @@
   "excludeNotExported": true,
   "mode": "file",
   "target": "es5",
-  "module": "es5",
+  "module": "es6",
   "lib": ["lib.es2015.d.ts", "lib.es2015.collection.d.ts", "lib.es2015.promise.d.ts", "lib.dom.d.ts"],
   "out": "../../docs/api/application",
   "baseUrl": ".",

diff --git a/packages/collections/package.json b/packages/collections/package.json
@@ -21,18 +21,27 @@
   "files": [
     "dist/*",
     "src/*",
-    "types/*"
+    "types/*",
+    "types-3.4/*"
   ],
   "main": "dist/index.js",
   "module": "dist/index.es6",
   "unpkg": "dist/index.min.js",
   "jsdelivr": "dist/index.min.js",
   "types": "types/index.d.ts",
+  "typesVersions": {
+    "<3.8": {
+      "*": [
+        "types-3.4/index.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "api": "api-extractor run --local --verbose",
     "minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
-    "build": "tsc --build && rollup -c",
+    "build": "tsc --build && npm run gen-legacy-types && rollup -c",
     "build:test": "tsc --build tests && cd tests && webpack",
+    "gen-legacy-types": "downlevel-dts ./types ./types-3.4",
     "clean": "rimraf ./lib && rimraf *.tsbuildinfo && rimraf ./types && rimraf ./dist",
     "clean:test": "rimraf tests/build",
     "docs": "typedoc --options tdoptions.json src",
@@ -49,6 +58,7 @@
     "@microsoft/api-extractor": "^7.6.0",
     "@types/chai": "^3.4.35",
     "@types/mocha": "^2.2.39",
+    "downlevel-dts": "^0.4.0",
     "tslib": "1.10.0",
     "chai": "^3.5.0",
     "karma": "^4.4.1",
@@ -64,12 +74,12 @@
     "rollup-plugin-sourcemaps": "^0.5.0",
     "rollup-plugin-postcss": "^2.0.3",
     "terser": "^4.6.2",
-    "typedoc": "~0.15.0",
-    "typescript": "~3.6.4",
+    "typedoc": "~0.17.7",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   },
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/collections/tdoptions.json b/packages/collections/tdoptions.json
@@ -2,7 +2,7 @@
   "excludeNotExported": true,
   "mode": "file",
   "target": "es5",
-  "module": "es5",
+  "module": "es6",
   "out": "../../docs/api/collections",
   "baseUrl": ".",
   "paths": {

diff --git a/packages/commands/package.json b/packages/commands/package.json
@@ -21,18 +21,27 @@
   "files": [
     "dist/*",
     "src/*",
-    "types/*"
+    "types/*",
+    "types-3.4/*"
   ],
   "main": "dist/index.js",
   "module": "dist/index.es6",
   "unpkg": "dist/index.min.js",
   "jsdelivr": "dist/index.min.js",
   "types": "types/index.d.ts",
+  "typesVersions": {
+    "<3.8": {
+      "*": [
+        "types-3.4/index.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "api": "api-extractor run --local --verbose",
     "minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
-    "build": "tsc --build && rollup -c",
+    "build": "tsc --build && npm run gen-legacy-types && rollup -c",
     "build:test": "tsc --build tests && cd tests && webpack",
+    "gen-legacy-types": "downlevel-dts ./types ./types-3.4",
     "clean": "rimraf ./lib && rimraf *.tsbuildinfo && rimraf ./types && rimraf ./dist",
     "clean:test": "rimraf tests/build",
     "docs": "typedoc --options tdoptions.json src",
@@ -62,6 +71,7 @@
     "@microsoft/api-extractor": "^7.6.0",
     "@types/chai": "^3.4.35",
     "@types/mocha": "^2.2.39",
+    "downlevel-dts": "^0.4.0",
     "tslib": "1.10.0",
     "chai": "^3.5.0",
     "es6-promise": "^4.0.5",
@@ -79,12 +89,12 @@
     "rollup-plugin-postcss": "^2.0.3",
     "terser": "^4.6.2",
     "simulate-event": "^1.4.0",
-    "typedoc": "~0.15.0",
-    "typescript": "~3.6.4",
+    "typedoc": "~0.17.7",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   },
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/commands/tdoptions.json b/packages/commands/tdoptions.json
@@ -2,7 +2,7 @@
   "excludeNotExported": true,
   "mode": "file",
   "target": "es5",
-  "module": "es5",
+  "module": "es6",
   "lib": ["lib.es2015.d.ts", "lib.es2015.collection.d.ts", "lib.es2015.promise.d.ts", "lib.dom.d.ts"],
   "out": "../../docs/api/commands",
   "baseUrl": ".",

diff --git a/packages/coreutils/package.json b/packages/coreutils/package.json
@@ -21,18 +21,27 @@
   "files": [
     "dist/*",
     "src/*",
-    "types/*"
+    "types/*",
+    "types-3.4/*"
   ],
   "main": "dist/index.js",
   "module": "dist/index.es6",
   "unpkg": "dist/index.min.js",
   "jsdelivr": "dist/index.min.js",
   "types": "types/index.d.ts",
+  "typesVersions": {
+    "<3.8": {
+      "*": [
+        "types-3.4/index.d.ts"
+      ]
+    }
+  },
   "scripts": {
     "api": "api-extractor run --local --verbose",
     "minimize": "terser dist/index.js -c -m --source-map \"content='dist/index.js.map',url='index.min.js.map'\" -o dist/index.min.js",
-    "build": "tsc --build && rollup -c",
+    "build": "tsc --build && npm run gen-legacy-types && rollup -c",
     "build:test": "tsc --build tests && cd tests && webpack",
+    "gen-legacy-types": "downlevel-dts ./types ./types-3.4",
     "clean": "rimraf ./lib && rimraf *.tsbuildinfo && rimraf ./types && rimraf ./dist",
     "clean:test": "rimraf tests/build",
     "docs": "typedoc --options tdoptions.json src",
@@ -49,6 +58,7 @@
     "@microsoft/api-extractor": "^7.6.0",
     "@types/chai": "^3.4.35",
     "@types/mocha": "^2.2.39",
+    "downlevel-dts": "^0.4.0",
     "tslib": "1.10.0",
     "chai": "^3.5.0",
     "es6-promise": "^4.0.5",
@@ -65,8 +75,8 @@
     "rollup-plugin-sourcemaps": "^0.5.0",
     "rollup-plugin-postcss": "^2.0.3",
     "terser": "^4.6.2",
-    "typedoc": "~0.15.0",
-    "typescript": "~3.6.4",
+    "typedoc": "~0.17.7",
+    "typescript": "~3.9.2",
     "webpack": "^4.41.3",
     "webpack-cli": "^3.3.10"
   },
@@ -76,4 +86,4 @@
   "browser": {
     "crypto": false
   }
-}
+}
diff --git a/packages/coreutils/src/json.ts b/packages/coreutils/src/json.ts
@@ -27,7 +27,7 @@ type JSONValue = JSONPrimitive | JSONObject | JSONArray;
  * A type definition for a JSON object.
  */
 export
-interface JSONObject { [key: string]: JSONValue; }
+interface JSONObject { [key: string]: JSONValue | ReadonlyJSONValue; }
 
 
 /**