Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese Documents #139

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Add Japanese Documents #139

merged 6 commits into from
Jul 7, 2023

Conversation

eltociear
Copy link
Contributor

I created Japanese translated documents.

@monkeyWie monkeyWie self-requested a review July 6, 2023 01:04
@monkeyWie
Copy link
Member

Thank you, are you interested in adding Japanese support to the gui?

@eltociear
Copy link
Contributor Author

@monkeyWie Yes.

@monkeyWie
Copy link
Member

Ok, you can refer to https://github.com/GopeedLab/gopeed/blob/main/ui/flutter/assets/locales to add Japanese language.

@eltociear
Copy link
Contributor Author

@monkeyWie Okay! I'll check it.

@eltociear
Copy link
Contributor Author

@monkeyWie Added GUI locale file.

@monkeyWie
Copy link
Member

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (32d2e46) 56.73% compared to head (c69af78) 56.90%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   56.73%   56.90%   +0.16%     
==========================================
  Files          15       15              
  Lines        1766     1766              
==========================================
+ Hits         1002     1005       +3     
+ Misses        639      637       -2     
+ Partials      125      124       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@monkeyWie monkeyWie merged commit 15d0296 into GopeedLab:main Jul 7, 2023
2 checks passed
@monkeyWie monkeyWie added the enhancement New feature or request label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants