Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-signing needAdditionalAuth does not notify #144

Closed
ktiedt opened this issue Apr 30, 2016 · 0 comments
Closed

google-signing needAdditionalAuth does not notify #144

ktiedt opened this issue Apr 30, 2016 · 0 comments

Comments

@ktiedt
Copy link
Contributor

ktiedt commented Apr 30, 2016

google-signin reflects all properties from google-signin-aware but it fails to notify this one which causes issues when you are not using the -aware component directly (and forces you to deep dive into the element to get the value).
@atotic atotic closed this as completed in 321e1dc May 2, 2016
atotic added a commit that referenced this issue May 2, 2016
@atotic
Merge pull request #145 from ktiedt/fix-notify
79a22a6 
Fixes #144. LGTM, merging to help with the merge backlog on this element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktiedt