Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observer syntax won't work, require comma separated arguments #138

Closed
sjmiles opened this issue Jun 7, 2015 · 0 comments
Closed

Observer syntax won't work, require comma separated arguments #138

sjmiles opened this issue Jun 7, 2015 · 0 comments
Assignees
@sjmiles
Labels
bug

Comments

@sjmiles
Copy link
Contributor

sjmiles commented Jun 7, 2015

Observer arguments must now be separated by commas, not simple whitespace.

Should be:

    observers: [
      '_updateCenter(latitude, longitude)'
    ],

insteadof

    observers: [
      '_updateCenter(latitude longitude)'
    ],

https://github.com/GoogleWebComponents/google-map/blob/master/google-map.html#L328
@sjmiles sjmiles added the bug label Jun 7, 2015
@sjmiles sjmiles self-assigned this Jun 7, 2015
@sjmiles sjmiles closed this as completed in 162f153 Jun 7, 2015
addyosmani added a commit that referenced this issue Jun 7, 2015
@addyosmani
Merge pull request #140 from GoogleWebComponents/sjm-fix-138-139
e90e13d 
observer arguments must be separated by commas (fix #138), relax type…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjmiles sjmiles

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjmiles