_authHandler called twice during login #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing called by the onAuth firebase function when the user state changes
|
agreed, this cause the 'login' to be fired twice... can this be fixed? |
|
LGTM. @cdata PTAL. |
|
LGTM |
ebidel
added a commit
that referenced
this pull request
Jan 20, 2016
_authHandler called twice during login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _authHandler function is being called twice whenever the login function is called (and succeeded). The _loginHandler is the callback function for all of the 'auth functions', when run and without error calls the _authHandler. At the same time, the onAuth firebase function (set on the _locationChanged function) will call the _authHandle whenever the authorization changes the state. For this reason, _authHandler on a valid login is being called twice and thus the 'login' event fired twice.
There is no need for the _loginHandler function (callback of the login function) to be run on succeed as the _authHandler function was already set up on the onAuth firebase function and will be called when the login is performed and the authorization changes of state.