Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user object was not passed as part of the user-created event object #59

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

ajit-kumar-azad
Copy link
Contributor

Firebase createUser API returns a user object, in case of success, and stamps the uid inside it. Updated the createUser method to return that user object as part of the event object when user-created event is fired.

Firebase createUser API returns a user object, in case of success, and stamps the uid inside it. Updated the createUser method to return that user object as part of the event object when user-created event is fired.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ajit-kumar-azad
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@chuckh
Copy link
Contributor

chuckh commented Jan 20, 2016

LGTM. @cdata PTAL.

@ebidel
Copy link
Contributor

ebidel commented Jan 20, 2016

LGTM

ebidel added a commit that referenced this pull request Jan 20, 2016
user object was not passed as part of the user-created event object
@ebidel ebidel merged commit cf566a4 into GoogleWebComponents:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants