-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color picker – Add full gradient support #497
Conversation
# Conflicts: # assets/src/edit-story/components/panels/style.js
Replying to various comments by @spacedmonkey:
Works for me. I can undo and redo each separate gradient change just fine - done with mouse or keyboard. Basically, if the actual page layout updates when you change any individual thing, each individual change will always create an entry in the history. It simply can't not happen.
You have many separate comments there, trying to address them individually:
I want to add a lot more testing to the color picker, but it's very time intensive. I am working on it, though. It'll be mostly integration testing for this complex component. @spacedmonkey for further comments and discussion, please if at all possible make them inline, as it's so much easier to have a conversation going in an inline thread rather than in disjoint comments on the main PR. I have linked to all relevant parts of the PR inline above. Thanks 😃 |
assets/src/edit-story/components/colorPicker/test/colorPicker.js
Outdated
Show resolved
Hide resolved
# Conflicts: # assets/src/edit-story/components/canvas/pagepreview/index.js # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work! 💪
Edit: Just noticed a small thing while looking at another PR, but I'd say this should be handled in a new PR.
Let's get this beast in first!
Full gradient support added in this PR.
With full test coverage for color picker, color input and all color-related util functions!
See it in action here: https://youtu.be/V3qsoONXUwk
Fully fixes #263.