Fix: Remove WP_Post type hint from prefill_post_content
#13430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuragVasanwala
added
Type: Bug
…ll_post_content-and-prefill_post_title-methods
AnuragVasanwala
changed the title
WP_Post type declaration from prefill_post_contentWP_Post type declaration from prefill_post_content
AnuragVasanwala
changed the title
WP_Post type declaration from prefill_post_contentWP_Post type declaration from prefill_post_content
|
Plugin builds for cdcccb4 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.74 MB ℹ️ View Unchanged
|
|
@swissspidy Minimum PHP version requirement for Also, would you please guide me for the failed test cases? |
swissspidy
reviewed
Jul 26, 2023
Ah yes, nullable works too I suppose. No need to add a test case. |
Co-authored-by: Pascal Birchler <[email protected]>
swissspidy
approved these changes
Jul 26, 2023
…ll_post_content-and-prefill_post_title-methods
swissspidy
changed the title
WP_Post type declaration from prefill_post_contentWP_Post type hint from prefill_post_content
swissspidy
deleted the
13405-remove-parameter-type-hints-from-prefill_post_content-and-prefill_post_title-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The goal of the PR is to fix fatal error when providing
nullvalue to the second parameter$postof the functionGoogle\Web_Stories\Admin\Admin::prefill_post_content().Summary
Supplying
nullvalue to the second parameter$postof the functionGoogle\Web_Stories\Admin\Admin::prefill_post_content()causes fatal error as the respected parameter type is explicitly defined asWP_Post. Thus, removingWP_Posttype and updatingphpdocresolves the issue.Relevant Technical Choices
Not applicable.
To-do
User-facing changes
Not applicable.
Testing Instructions
Not applicable.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZlabel to the PRFixes #13405