Bump WP version requirement to 6.1 #13413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Task
|
Size Change: -17 B (0%) Total Size: 2.74 MB ℹ️ View Unchanged
|
|
Plugin builds for 37a04b2 are ready 🛎️!
|
AnuragVasanwala
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
@swissspidy Two queries related to the version constants otherwise LGTM! ✅
Query
May we also update version constants as per the new version in the following files?
File 1: web-stories.php
- Line 50: define( 'WEBSTORIES_MINIMUM_WP_VERSION', '6.0' );
+ Line 50: define( 'WEBSTORIES_MINIMUM_WP_VERSION', '6.1' );File 2: /tests/phpstan/bootstrap.php
- Line 13: define( 'WEBSTORIES_MINIMUM_PHP_VERSION', '5.6' );
+ Line 13: define( 'WEBSTORIES_MINIMUM_PHP_VERSION', '7.4' );
- Line 14: define( 'WEBSTORIES_MINIMUM_WP_VERSION', '5.3' );
+ Line 14: define( 'WEBSTORIES_MINIMUM_WP_VERSION', '6.1' );
9 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See #13260
Summary
Bumps the WordPress minimum version requirement to 6.1.
Removes now unneeded code that primes some caches, because WP 6.1+ already does this.
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #13260