Video Trimming: Avoid crash due to missing tracks property
#12556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Bug
|
Plugin builds for e014eb1 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
|
As per the ticket, we should add a data migration. And of course ideally fix the root cause |
This fix, fixes the problem. What is the point of adding a migration? |
|
Looks like In that case please fix the lint errors and then I think we can merge it. |
swissspidy
approved these changes
Nov 1, 2022
swissspidy
changed the title
tracks propertytracks property
timarney
approved these changes
Nov 3, 2022
|
@swissspidy - I was not able to find the branch within the web-stories-tester that would allow me to test this fix in isolation on stories-qa test site. To confirm this was fixed, I also recreated the crash in another branch that did not have the merged code. However, I noticed that the #12471 issue was closed. So i tested this crash by trimming the video on 5th page of the specific story that I had mentioned in that ticket. And the crash did not occur. Reporting this here since this ticket is sitting in Ready-for-QA although the fix seems to have been merged in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Set the default value of tracks in trim component to an empty array. This brings this compontent inline with others like this, this and this.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12471