Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert i18n package to TypeScript #12198

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Convert i18n package to TypeScript #12198

merged 5 commits into from
Sep 1, 2022

Conversation

swissspidy
Copy link
Collaborator

Context

Part of the TS migration, see #1715

Summary

Converts the i18n package to TypeScript.

Relevant Technical Choices

  • Updated ESLint config to reduce redundancy when using TypeScript. No need to declare types in JSDoc when they're already enforced with TS.

To-do

User-facing changes

N/A

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12180

@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: WP Package: I18N /packages/i18n labels Aug 31, 2022
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 31, 2022

Plugin builds for da6754b are ready 🛎️!

@swissspidy swissspidy removed the request for review from spacedmonkey August 31, 2022 14:59
Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.eslintrc Show resolved Hide resolved
@swissspidy swissspidy merged commit 56af426 into main Sep 1, 2022
@swissspidy swissspidy deleted the add/12180-ts-i18n branch September 1, 2022 13:04
@swissspidy swissspidy mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: I18N /packages/i18n Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript: Convert i18n package
3 participants