Typescript 5 support #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredTreg
force-pushed
the
typescript-5-support
branch
from
5605ca8 to
fc4bf9b
Compare
Owner
|
Hello, thank you so much for the pull request. I'm currently working on the next version of this library over at the Thanks! |
Contributor
Author
|
I'll send several PRs on dev then. Typescript 5 support was just prep work for the real PR I'm interested in: null vs undefined support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to TypeScript 5.1 and fixed corresponding compiling issues.
There were issues with
ts.Expressionvsts.Node. I fixed as I could but could not help aas ts.Expressionwhich I do not fully understand.I used
ts-patchfor testing as it is the current drop-in replacement forttypescriptwhich does not support TS 5. See nonara/ts-patch#93 (comment) for more contextI have not added code to support TS 5 decorators, so I guess they will not work.