Add buffering for large layers. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
force-pushed
the
buffer
branch
5 times, most recently
from
a718d46 to
acffacc
Compare
bobcatfish
reviewed
Nov 2, 2018
bobcatfish
reviewed
Nov 2, 2018
| @@ -55,32 +54,16 @@ func (s *Snapshotter) Key() (string, error) { | |||
|
|
|||
| // TakeSnapshot takes a snapshot of the specified files, avoiding directories in the whitelist, and creates | |||
| // a tarball of the changed files. Return contents of the tarball, and whether or not any files were changed | |||
| func (s *Snapshotter) TakeSnapshot(files []string) ([]byte, error) { | |||
| buf := bytes.NewBuffer([]byte{}) | |||
There was a problem hiding this comment.
it looks like you decided to move this buffering up a layer - personally i think it's nicer for the caller not to have to worry about it but either way, maybe the commit message could go into some detail about why that choice was made?
bobcatfish
reviewed
Nov 2, 2018
bobcatfish
reviewed
Nov 2, 2018
pkg/executor/build.go
Outdated
|
|
||
| if !s.shouldTakeSnapshot(index, files) { | ||
| continue | ||
| } | ||
|
|
||
| f, err := ioutil.TempFile("/kaniko", "") |
There was a problem hiding this comment.
is there any case where we would want this to be in-memory instead? (i.e. configurable)
There was a problem hiding this comment.
I don't think so - I think if anything the path itself here would be configurable. Using a tmp or memfs directory should be basically the same thing as in memory vs. on disk.
dlorenc
force-pushed
the
buffer
branch
3 times, most recently
from
d1c2caa to
9f75451
Compare
dlorenc
commented
Nov 5, 2018
priyawadhwa
approved these changes
Nov 5, 2018
When building Docker images, layers were previously stored in memory. This caused obvious issues when manipulating large layers, which could cause Kaniko to crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes layer tarballs to disk rather than keeping them all in memory.
#358