Refactor the build loop. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @priyawadhwa |
dlorenc
force-pushed
the
refactorbuild
branch
4 times, most recently
from
744b0f4 to
c725529
Compare
This change refactors the build loop a bit to make cache optimization easier in the future. Some notable changes: The special casing around volume snapshots is removed. Every volume is added to the snapshotFiles list for every command that will snapshot anyway. Snapshot saving was extracted to a sub-function The decision on whether or not to snapshot was extracted
|
OK, tests finally passing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the build loop a bit to make cache optimization easier in the future. Some notable changes: