-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework cache key generation a bit. #375
Conversation
/wip |
dc545e9
to
5f8261e
Compare
This should be ready for a review now. |
I really like the CompositeCache idea! So I was using the current state of the filesystem for Dockerfiles like this:
With this switch, if foo is changed then the entire Dockerfile will be rebuilt, even though the first RUN command may have been cached on a previous run and could still be used. Instead of the entire source context, WDYT of adding the snapshotted files as they're added by each command? (I think that should work but not 100% sure). |
d6d6fef
to
6434208
Compare
Cache keys are now based on the previous commands, rather than the previous state of the filesystem.
9bd6f5b
to
a20f002
Compare
Whoo, finally passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cache keys are now based on the previous commands, rather than the previous state
of the filesystem.
This will allow us to add some further optimizations to caching.
Still needs some tests.