-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a whitelist issue when untarring files in ADD commands. #371
Conversation
6b42cd5
to
86dd272
Compare
Looks like kokoro caught something
|
9224e25
to
7e91d60
Compare
integration-test.sh
Outdated
@@ -35,4 +35,4 @@ fi | |||
echo "Running integration tests..." | |||
make out/executor | |||
pushd integration | |||
go test -v --bucket "${GCS_BUCKET}" --repo "${IMAGE_REPO}" --timeout 30m | |||
go test -v --bucket "${GCS_BUCKET}" --repo "${IMAGE_REPO}" --timeout 30m -run ^TestRun/Dockerfile_test_add$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be left over from testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh. Thanks!
7e91d60
to
a7a290f
Compare
Cool so kokoro found this:
This is one of the images we test the |
Thanks! |
a7a290f
to
b6c0572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think this fixes an issue with extracting tar files during ADD commands where those tar files contain whitelisted entries.