-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist /busybox in the debug image #369
Whitelist /busybox in the debug image #369
Conversation
Hi @vbehar. Thanks for your PR. I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @vbehar, instead of hardcoding
|
In the debug image, declare /busybox as a volume so that it is automatically whitelisted, because we don't want to delete it when building multi-stages images. FYI this is required when using Jenkins, because we need to use the debug kaniko image to be able to start the container "doing nothing" (with /busybox/cat) before building (by executing /kaniko/executor directly inside the container) See https://issues.jenkins-ci.org/browse/JENKINS-52576
f47c631
to
d10e3f5
Compare
@priyawadhwa ok thanks, yes that's way better (and easier) that way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
Thanks for your review and your good work on Kaniko ! |
I'm still experiencing this issue in Jenkins @vbehar . Jenkins on a Kubernetes cluster, starting the kaniko container with /busybox/cat. In my pipeline I run most of my job on a linux agent, but want to swap to kaniko container for docker images. Receiving the nohup error. Any advice for how you got it working? Trying to run even a sh 'ls' returns '/busybox/sh: nohup: not found' edit: disregard. For anyone who sees this I had to add a withEnv(['PATH+EXTRA=path-from-kaniko-container']) |
In the debug image, declare /busybox as a volume so that it is automatically whitelisted, because we don't want to delete it when building multi-stages images.
FYI this is required when using Jenkins, because we need to use the debug kaniko image to be able to start the container "doing nothing" (with /busybox/cat) before building (by executing /kaniko/executor directly inside the container)
See https://issues.jenkins-ci.org/browse/JENKINS-52576