-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate --insecure-skip-tls-verify flag into two separate flags #311
Separate --insecure-skip-tls-verify flag into two separate flags #311
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Hi @DerDackel. Thanks for your PR. I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1bfee74
to
ab7c5b5
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! This looks good to me overall, could you also update the README to include these flags in the Additional Flags
section?
pkg/options/options.go
Outdated
SrcContext string | ||
SnapshotMode string | ||
Bucket string | ||
DockerInsecure bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename DockerInsecure
to something which doesn't include Docker in the name, maybe InsecurePush
?
Done and done. I took the liberty of adding a warning about their intended use to both flags. |
Thanks! I think you just have to rebase against master and this should be good. |
…S verification into two separate command line parameters
af28a48
to
1a7de69
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this!
Possibly fixes #310