Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-containerregistry so that kaniko works with Harbor #227

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Jul 6, 2018

Hi! Thanks for maintaining the great project!

Recently, I confirmed current version of kaniko doesn't work well with Harbor as I stated two issues below:

After my research, I understand the reason might be harbor's implementation. However, my workaround(google/go-containerregistry#219) was merged in go-containerregistry to make go-containerregistry more robust on various docker container registry implementations even when some implementations doesn't follow the docker registry specs. Also, another issue(google/go-containerregistry#220) reported that exactly the same error happens in gitlab.

So, I would like kaniko to pull the change so that kaniko works nicely with private docker registry implementations (at least with harbor, gitlab).

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@everpeace everpeace force-pushed the update-go-containerregistry branch from 55069c4 to 8a7e2a3 Compare July 6, 2018 08:26
@googlebot
Copy link

CLAs look good, thanks!

@priyawadhwa
Copy link
Collaborator

priyawadhwa commented Jul 6, 2018

Hey @everpeace, since this is a change to go-containerregistry, you'll have to submit this change in that repo first and then we can vendor in the changes.

Edit: Whoops just realized that's exactly what you did (sorry, somehow I must have not fully read the PR description!)

@priyawadhwa
Copy link
Collaborator

Thanks so much for contributing!

@priyawadhwa priyawadhwa merged commit 19287f8 into GoogleContainerTools:master Jul 6, 2018
@everpeace
Copy link
Contributor Author

everpeace commented Jul 8, 2018

@priyawadhwa Thanks for merging this! Would you mind me telling when gcr.io/kaniko-project/executor:{latest, debug} will be updated??

I expected those images were updated after this PR being merged. But it seems not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants