rename default home function

GoogleContainerTools · Aug 10, 2018 · 8ba0648 · 8ba0648
1 parent 16139c2
commit 8ba0648
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/commands/run.go b/pkg/commands/run.go
@@ -61,7 +61,7 @@ func (r *RunCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.Bui
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	replacementEnvs := buildArgs.ReplacementEnvs(config.Env)
-	cmd.Env = addDefaultEnvs(config.User, replacementEnvs)
+	cmd.Env = addDefaultHOME(config.User, replacementEnvs)
 	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
 
 	// If specified, run the command as a specific user
@@ -115,8 +115,8 @@ func (r *RunCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.Bui
 	return nil
 }
 
-// addDefaultEnvs adds default values of variables (like $HOME) if they aren't already set
-func addDefaultEnvs(user string, envs []string) []string {
+// addDefaultHOME adds the default value for HOME if it isn't already set
+func addDefaultHOME(user string, envs []string) []string {
 	for _, env := range envs {
 		split := strings.SplitN(env, "=", 2)
 		if split[0] == constants.HOME {

diff --git a/pkg/commands/run_test.go b/pkg/commands/run_test.go
@@ -21,7 +21,7 @@ import (
 	"github.com/GoogleContainerTools/kaniko/testutil"
 )
 
-func Test_addDefaultEnvs(t *testing.T) {
+func Test_addDefaultHOME(t *testing.T) {
 	tests := []struct {
 		name     string
 		user     string
@@ -65,7 +65,7 @@ func Test_addDefaultEnvs(t *testing.T) {
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			actual := addDefaultEnvs(test.user, test.initial)
+			actual := addDefaultHOME(test.user, test.initial)
 			testutil.CheckErrorAndDeepEqual(t, false, nil, test.expected, actual)
 		})
 	}