[issue #4175] SpringBootExplodedProcessor now uses JAR's Main-Class w…#4177
Open
stefan-prange wants to merge 1 commit intoGoogleContainerTools:masterfrom
Open
[issue #4175] SpringBootExplodedProcessor now uses JAR's Main-Class w…#4177stefan-prange wants to merge 1 commit intoGoogleContainerTools:masterfrom
stefan-prange wants to merge 1 commit intoGoogleContainerTools:masterfrom
Conversation
…s JAR's Main-Class when creating the target image's entrypoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hen creating the target image's entrypoint
Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.
Before filing a pull request, make sure to do the following:
-> Done: see JIB-CLI uses outdated classname in entrypoint when dockerzing a Spring-Boot-3.2 executable JAR. #4175
-> I hope so. Bugfixing is always a good idea, isn't it?
-> All unit tests passed, but one of the integration tests failed on my machine (WarCommandTest). That's not related to my code additions because running the integration test on master came to the same result.
the style guide.
-> I ran the auto-formatter, so I hope my additions comply with your styling preferences.
This helps to reduce the chance of having a pull request rejected.
Fixes #4175 🛠️