This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Remove characters from cache path that are invalid on Windows #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverar
requested review from
aaron-prindle,
dlorenc and
nkubala
as code owners
nkubala
suggested changes
Jan 16, 2019
|
Changes made per review, also reverted @nkubala's colon change to encourage helper function usage. |
nkubala
approved these changes
Feb 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
Cherry picked common invalid characters. Note, this changes expected locations for images that are stored on disk at locations containing these characters. This change may unexpectedly result in image re-caching.