Skip to content

Conversation

briandealwis
Copy link
Member

This applies the change in fabioz/PyDev.Debugger#199 to pydevd, and adds support to the Python launcher to use this new --continue flag.

// From the pydevd source, PyCharm wants multiproc
cmdline = append(cmdline, "--multiproc")
}
if !pc.wait {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding - how will this get passed in? does skaffold hardcode this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the --wait flag. It's currently not supported in Skaffold (GoogleContainerTools/skaffold#4870).

Copy link

@etanshaul etanshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM, there was just one other comment in here mainly just for my understanding

@briandealwis briandealwis merged commit c398cd9 into GoogleContainerTools:duct-tape May 18, 2021
@briandealwis briandealwis deleted the pydevd-continue branch May 18, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants