Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zetasql-toolkit depends on concrete slf4j-simple #24

Closed
hamnis opened this issue Oct 17, 2023 · 3 comments · Fixed by #37
Closed

zetasql-toolkit depends on concrete slf4j-simple #24

hamnis opened this issue Oct 17, 2023 · 3 comments · Fixed by #37

Comments

@hamnis
Copy link
Contributor

hamnis commented Oct 17, 2023

It should either be in test-scope or optional.

for now an exclusion is needed if you use any other slf4j backend.

@hamnis hamnis changed the title zetasql-toolkit depends on concrete sl4j-simple zetasql-toolkit depends on concrete slf4j-simple Oct 17, 2023
ppaglilla added a commit that referenced this issue Oct 17, 2023
@ppaglilla
Copy link
Collaborator

Thanks for calling this out!

I removed both the slf4j-api and slf4j-simple dependencies from zetasql-toolkit-core, neither were required. The next release (0.5.0) will not include them and should be released in just a few days.

zetasql-toolkit-bigquery will still depend on slf4j-api:1.7.25, since that is a transitive dependency of the BigQuery client library.

@hamnis
Copy link
Contributor Author

hamnis commented Mar 6, 2024

@ppaglilla any chance of getting a release which fixes this out ?

@ppaglilla
Copy link
Collaborator

Apologies for the delayed responses here! I'm releasing a new version with this fix in the next few days, likely as soon as we merge #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants