add ClientDefaultListenerResourceNameTemplate when used with --include-xdstp-name-in-lds-experimental #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--include-xdstp-name-in-lds-experimental
currently only adds in the TDOM authority to the authorities map. For xDS dial targets without an authority to default to the new xDSTP style name and use the TDOM authority, the flag should addclient_default_listener_resource_name_template
to the config.Behavior changes to gRPC client after this change:
Example 1: When no authority specified in dial target
If a gRPC client channel is created for
xds:server.example.com
client_default_listener_resource_name_template
field. The resulting resource name will bexdstp://traffic-director-global.xds.googleapis.com/envoy.config.listener.v3.Listener/123456789012345/thedefault/server.example.com
.authorities
map.client_listener_resource_name_template
field in theauthorities
entry, since we've already used the top-levelclient_default_listener_resource_name_template
field to construct the resource name.xds_server
list is not specified in the entry for the authority, so we default to the top-levelxds_server
list, which is the same one that we would have used prior to this design.Example 2: When TDOM authority specified in dial target
If a gRPC client channel is created for
xds://traffic-director-global.xds.googleapis.com/server.example.com
authorities
map.client_listener_resource_name_template
field in theauthorities
entry to construct the resource name which results inxdstp://traffic-director-global.xds.googleapis.com/envoy.config.listener.v3.Listener/123456789012345/thedefault/server.example.com
.xds_server
list is not specified in the entry for the authority, so we default to the top-levelxds_server
list, which is the same one that we would have used prior to this design.Path to stabilizing this flag: