Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Conversation

modular-magician
Copy link
Collaborator

Some were using the beta provider but all functionality seems to be GA; others didn't have the beta provider declared on all resources. I need to run GA tests for the tests being added to GA.

Resolved hashicorp/terraform-provider-google#12154

Added to GA:

TestAccCloudRunService_cloudRunServiceConfigurationExample|TestAccCloudRunService_cloudRunSystemPackagesExample|TestAccCloudRunService_cloudrunServiceIdentityExample|TestAccCloudRunService_cloudRunServiceScheduledExample

Modified in Beta:

TestAccCloudRunService_cloudRunServiceStaticOutboundExample

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6317

…on if needed (#6317)

* Corrected cloud run service tests to only use beta provider declaration if needed

* Made TestAccCloudRunService_cloudRunServiceScheduledExample run in GA

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner July 22, 2022 20:43
@modular-magician modular-magician requested review from melinath and removed request for a team July 22, 2022 20:43
@modular-magician modular-magician merged commit 709d54e into GoogleCloudPlatform:main Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudRunService_*
1 participant