Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlockingFunctionsConfig, RecaptchaConfig and QuotaConfig fields to identityplatform config #1211

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add BlockingFunctionsConfig, RecaptchaConfig and QuotaConfig fields to identityplatform config #1211

merged 1 commit into from
Jul 28, 2023

Conversation

modular-magician
Copy link
Collaborator

Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to identityplatform config

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

identityplayform: added support for `blocking_functions` `quota` and `authorized_domains` in `google_identity_platform_config`

Derived from GoogleCloudPlatform/magic-modules#8402

@modular-magician
Add BlockingFunctionsConfig, RecaptchaConfig and QuotaConfig fields t…
8ed9e1a 
…o identityplatform config (#8402)

* Add Add BlockingFunctionsConfig, AuthorizedDomains and QuotaConfig fields to Config.yaml

* adding new fields to identity_platform_config_basic.tf.erb

* Update Config.yaml

Temporarily enable VCR to run the tests. Also, provide a more user's friendly desc for the quota field.

* Fix the failing test

* Update Config.yaml

Fix the quota start_time format.

* Attempt 2: Fix the failing test

* Update Config.yaml Enabling VCR.

* Update Config.yaml

Re-enable skip_vcr due to hashicorp/terraform-provider-google#14158.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner July 28, 2023 15:33
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team July 28, 2023 15:33
@modular-magician modular-magician merged commit 1f39c21 into GoogleCloudPlatform:main Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottSuarez ScottSuarez Awaiting requested review from ScottSuarez ScottSuarez is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician