fix(test): add mock method to mock credentials. #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75c51a9.
| return () -> mock(Credentials.class); | ||
| Credentials mockCredential = mock(Credentials.class); | ||
| when(mockCredential.getMetricsCredentialType()) | ||
| .thenReturn(CredentialTypeForMetrics.DO_NOT_SEND); |
There was a problem hiding this comment.
If mock credentials were placed in core, could you avoid the duplication here?
There was a problem hiding this comment.
The mock credentials are placed under "test" folder, not accessible here.
spring-cloud-gcp-autoconfigure/src/test/java/com/google/cloud/spring/autoconfigure/TestUtils.java
Created another util class in this module to avoid duplicating logic.
JoeWang1127
reviewed
Oct 22, 2024
| import com.google.auth.Credentials; | ||
|
|
||
| public class TestUtils { | ||
| public static final Credentials MOCK_CREDENTIALS = createMockCredentials(); |
There was a problem hiding this comment.
unfortunately, this is needed from classes in sub-packages within com.google.cloud.spring.autoconfigure.
burkedavison
approved these changes
Oct 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to avoid runtime error when creating the client bean #3307 (comment)
Adding a mock return for
getMetricsCredentialType()because in gax we do not allow for null values (should not happen because default is set)Also added together in this pr so ci could pass:
BEGIN_COMMIT_OVERRIDE
fix(deps): update dependency com.google.cloud:libraries-bom to v26.49.0
fix(test): add mock method to mock credentials.
END_COMMIT_OVERRIDE