Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fix): refactor SQL query assertions in SpannerStatementQueryExecutor.getChildrenRowsQuery to prevent flakiness #3297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

williamlin0825
Copy link

Related to issue: #3290

A test in the API getChildrenRowsQueryTest checks for the result from getSQL() from SpannerStatementQueryExecutor.getChildrenRowsQuery. However, it checks the result in a specific order, which is not guaranteed. Here is the affected test:

assertThat(statement.getSql())
.isEqualTo(
"SELECT deleted, id3, id, id_2 FROM child_test_table WHERE ((id = @tag0 AND id_2 ="
+ " @tag1)) AND (deleted = false)");

This PR propose to simply check whether the selected field names are correct instead of checking in a specific order.

@williamlin0825 williamlin0825 requested a review from a team as a code owner October 11, 2024 04:00
Copy link

google-cla bot commented Oct 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant