test(fix): refactor SQL query assertions in SpannerStatementQueryExecutor.getChildrenRowsQuery to prevent flakiness #3297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #3290
A test in the API
getChildrenRowsQueryTest
checks for the result fromgetSQL()
fromSpannerStatementQueryExecutor.getChildrenRowsQuery
. However, it checks the result in a specific order, which is not guaranteed. Here is the affected test:spring-cloud-gcp/spring-cloud-gcp-data-spanner/src/test/java/com/google/cloud/spring/data/spanner/repository/query/SpannerQueryLookupStrategyTests.java
Lines 176 to 179 in 05ad3ef
This PR propose to simply check whether the selected field names are correct instead of checking in a specific order.