Firestore - optimistic locking #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-s
changed the title
meltsufin
requested changes
Dec 10, 2020
...p-data-firestore/src/main/java/com/google/cloud/spring/data/firestore/FirestoreTemplate.java
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/spring/data/firestore/mapping/FirestoreDefaultClassMapper.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/cloud/spring/data/firestore/mapping/FirestorePersistentEntityImpl.java
Outdated
Show resolved
Hide resolved
...-data-firestore/src/main/java/com/google/cloud/spring/data/firestore/mapping/UpdateTime.java
Outdated
Show resolved
Hide resolved
dzou
reviewed
Dec 10, 2020
There was a problem hiding this comment.
Based on the in person review it looks good on my end.
However it looks like the integration tests may have broken; the error appears related to this feature:
Error: writeReadDeleteTest Time elapsed: 3.249 s <<< ERROR!
io.grpc.StatusRuntimeException: FAILED_PRECONDITION: the stored version (0) does not match the required base version (1607632501741884)
…gcp into firestore-optimistic-locking
meltsufin
reviewed
Dec 29, 2020
| this.firestoreTemplate.saveAll(Flux.just(bob)).as(operator::transactional).collectList() | ||
| .as(operator::transactional) | ||
| .as(StepVerifier::create) | ||
| .expectError() |
There was a problem hiding this comment.
Need to check the cause such that it is due to violation of optimistic locking.
There was a problem hiding this comment.
Created #187 to track this.
meltsufin
approved these changes
Dec 30, 2020
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: spring-attic/spring-cloud-gcp#2498